fix: attach all logs on chart failure #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log attachments in Sentry only contain the logs from the failed pod, not all pods. Very often it's the bootloader that's failed, but the bootloader logs don't say anything interesting – they just say the bootloader can't connect to the DB. So this PR would attach all logs from platform pods (only on airbyte chart failure) which hopefully gives us something more interesting to look at.
Java log parse code gets removed
The code I wrote to try to parse java logs from the platform in
diagnoseAirbyteChartFailure
is mostly a failure. Most of the time it just returnsThere are a few variants in the telemetry, such as:
These don't seem very clear for the user. The code to parse java logs lines is clunky and broken and not clearly valuable, so I've removed it in this PR. When the bootloader is the only failed pod, I return an error with a help message that says to run again with
--verbose
to see the full bootloader logs.